[PreferencePage] Wrong paths are being allowed #103
Assignees
Labels
bug
Something isn't working
Comments
jonas-jonas
pushed a commit
that referenced
this issue
Jul 17, 2019
fixes #103 Signed-off-by: Jonas Hungershausen <[email protected]>
jonas-jonas
pushed a commit
that referenced
this issue
Jul 19, 2019
fixes #103 Signed-off-by: Jonas Hungershausen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #99 was merged, there are still a few paths that are detected as correct paths:
This is because for the check to detect these paths,
bin/dartis appended to the end of the path./bin/dart(which is/+bin/dart) evaluates to/usr/bin/dart(which is/usr+bin/dart) which is a symlink to/usr/lib/dart/bin/dart, which is technically working it's just not very pretty.My suggestions would be to "blacklist"
/and/usras paths and always return false if these are entered. WDYT?The text was updated successfully, but these errors were encountered: