-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-detect Dart SDK in preference page does not work for existing workspace #83
Comments
Some how Files.exist returns true for emply location
|
workspace eclipse#83 Signed-off-by: Lakshminarayana Nekkanti <[email protected]>
workspace eclipse#83 Signed-off-by: Lakshminarayana Nekkanti <[email protected]>
In my experience it returns true for all files and directories. That being said, if the input is empty it just uses the current working directory (in this case the workspace location). Both of these problems can be fixed if I find a way to verify that the entered file is a valid Dart SDK executable. Though I'm not sure about the best way to do this.
Currently, I'm favoring 1. but I'm not sure how future proof this is, as the output could change and thus require us to change the pattern to match it again. |
…sting workspace eclipse#83" This reverts commit 00a495e.
existing workspace eclipse#83" This reverts commit 00a495e. Signed-off-by: Lakshminarayana Nekkanti <[email protected]>
#85) Signed-off-by: Lakshminarayana Nekkanti <[email protected]>
closes #83 Signed-off-by: Jonas Hungershausen <[email protected]>
As discussed if I start Eclipse for an existing workspace, the Dart SDK is wrongly configured as the WS location.
To test: Delete Dart SDK and restart Eclipse, check preference page.
The text was updated successfully, but these errors were encountered: