Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for valid Dart SDK to preference page #99

Merged
merged 11 commits into from
Jul 16, 2019
Merged

Add check for valid Dart SDK to preference page #99

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebbb093
Add check for valid Dart SDK to preference page
Jul 12, 2019
63fbddb
Adds better checks
Jul 12, 2019
e6f4147
Remove resolving /bin/dart automatically, as it caused problems
Jul 13, 2019
9d4474f
Add correct syntax for windows based platforms
Jul 13, 2019
00b6ade
Use File.seperator instead of "/"
Jul 13, 2019
4721129
Merge branch 'master' into issue-83
Jul 13, 2019
c7c2463
Remove System.err statement
Jul 13, 2019
877e87a
Add more windows specific stuff
Jul 13, 2019
ad2eca0
Fix windows cmd syntax
Jul 16, 2019
1ac76a1
Remove 2nd .exe
Jul 16, 2019
12ae4d7
Syntax update for windows CLI
Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion org.eclipse.dartboard/src/org/eclipse/dartboard/preference/DartSDKLocationFieldEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.eclipse.dartboard.preference;

import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.nio.file.Files;
Expand Down Expand Up @@ -65,7 +66,7 @@ private boolean isValidDartSDK(String location) {
// InvalidPathException is thrown. In that case we can assume that the location
// entered is not a valid Dart SDK directory either.
try {
path = Paths.get(location).resolve("bin/dart");
path = Paths.get(location).resolve("bin" + File.separator + "dart");
jonas-jonas marked this conversation as resolved.
Show resolved Hide resolved
} catch (InvalidPathException e) {
return false;
}
Expand Down