Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad .git matcher in .project's filteredResources causes chaos #2244

Closed
fbricon opened this issue Sep 27, 2022 · 2 comments · Fixed by #2251
Closed

bad .git matcher in .project's filteredResources causes chaos #2244

fbricon opened this issue Sep 27, 2022 · 2 comments · Fixed by #2251

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 27, 2022

jdt.ls adds resource filters to .project files, one of those filters matching .git. This caused me to lose several hours trying to figure out why https://github.com/tesla/m2eclipse-egit wasn't compiling in Eclipse, after opening it once in vscode.

.git matches folders like foo.egit, causing classes in subfolders to be entirely ignored by the compiler. Attached demo.zip project shows how bad that is:

Screenshot 2022-09-27 at 09 27 18

The fix seems to be escaping .git as \.git. But even manual fixes are then overridden after a server restart.

@fbricon fbricon added the bug label Sep 27, 2022
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Sep 28, 2022
@rgrunber rgrunber added this to the End September milestone Sep 28, 2022
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Sep 28, 2022
rgrunber pushed a commit that referenced this issue Sep 28, 2022
Fixes #2244

Signed-off-by: Fred Bricon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants