Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin gradle files? #449

Closed
fbricon opened this issue Nov 17, 2017 · 5 comments
Closed

Support Kotlin gradle files? #449

fbricon opened this issue Nov 17, 2017 · 5 comments

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 17, 2017

Buildship added support for kotlin: https://github.com/eclipse/buildship/tree/master/org.eclipse.buildship.kotlin

We need to evaluate whether we should embed that plugin as well, or let 3rd party adopters implement a jdt.ls extension for that.

@gorkem
Copy link
Contributor

gorkem commented Nov 27, 2017

I do not see why we should not include kotlin support? If a project prefers to use kotlin we should be able to import it.

@gatesn
Copy link
Contributor

gatesn commented Dec 5, 2017

@fbricon are there any docs you could point me at for how one might implement a jdt.ls extension?

Context: I'm running the LS behind a proxy so the gradlew file in the repo won't build by default. I'd prefer for the LS to use a gradle distribution URI or GRADLE_HOME from the environment ahead of using the workspace's gradlew.

@fbricon
Copy link
Contributor Author

fbricon commented Dec 5, 2017

@gatesn our wiki is unfortunately incomplete. You might want to look into https://github.com/gorkem/jdt.ls.pde as an exemple though

Whose gradlew file won't build? The users', the server's? Is it related to Kotlin support?

@gatesn
Copy link
Contributor

gatesn commented Dec 5, 2017

No, sorry hijacked the ticket a little bit. Here's new one: #480

@fbricon
Copy link
Contributor Author

fbricon commented Sep 9, 2021

Was fixed with #1849

@fbricon fbricon closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants