Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build selected projects #2138

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Jun 23, 2022

  • Add a new extended LSP request 'java/buildProjects' to support updating
    selected projects.

part of redhat-developer/vscode-java#2510, requires redhat-developer/vscode-java#2526

Signed-off-by: sheche [email protected]

- Add a new extended LSP request 'java/buildProjects' to support updating
  selected projects.

Signed-off-by: sheche <[email protected]>
@CsCherrYY
Copy link
Contributor

if the project has errors, can we show a notification to guide the user to open PROLBEMS panel instead of the current behavior?

image

@jdneo
Copy link
Contributor Author

jdneo commented Jun 29, 2022

Or we can simply resolve and return the result here instead of reject.

https://github.com/redhat-developer/vscode-java/blob/e6615a2bc72aa78299485efc5d94064e4f9e34b6/src/standardLanguageClient.ts#L448-L452

// I copied the same logic from compile workspace command.

@jdneo
Copy link
Contributor Author

jdneo commented Jun 29, 2022

Updated at client side: redhat-developer/vscode-java@b2d1749

@jdneo jdneo merged commit a996b57 into eclipse-jdtls:master Jun 29, 2022
@jdneo jdneo deleted the cs/issue-2510 branch June 29, 2022 07:13
@jdneo jdneo mentioned this pull request Jun 29, 2022
@rgrunber rgrunber added this to the End June 2022 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants