-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rebuild selected projects #2526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new extended LSP request: BuildProjectRequest. - The 'isFullBuild' is set to true by default in the request param. Signed-off-by: sheche <[email protected]>
Signed-off-by: sheche <[email protected]>
snjeza
approved these changes
Jun 23, 2022
CsCherrYY
reviewed
Jun 29, 2022
Signed-off-by: Sheng Chen <[email protected]>
@CsCherrYY PR updated. Meanwhile, I also make the first argument of the command either |
Signed-off-by: Sheng Chen <[email protected]>
CsCherrYY
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sheng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2510, requires eclipse-jdtls/eclipse.jdt.ls#2138
identifiers
- uri andisFullBuild
- boolean.Currently,
isFullBuild
is always set to true. Since we enable auto-build by default, triggering an incremental build does not make much sense. But a clean full build is helpful when the build status is out of sync. In the future, if users ask for incremental build support, we can expose this param.The name of the command is called
Rebuild Projects
now, indicates it will clean and do a full build.Signed-off-by: sheche [email protected]