Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove encoding for password changing #3570

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

MDeLuise
Copy link
Contributor

@MDeLuise MDeLuise commented Jul 5, 2022

Brief description of the PR
This PR fixes #3569, i.e. removes the encoding for special characters while updating a user password.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #3570 (fcf7091) into develop (e74c69f) will decrease coverage by 20.65%.
The diff coverage is 22.16%.

❗ Current head fcf7091 differs from pull request most recent head b50b21f. Consider uploading reports for the commit b50b21f to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3570       +/-   ##
==============================================
- Coverage      50.20%   29.54%   -20.66%     
+ Complexity       259       72      -187     
==============================================
  Files           1651     1662       +11     
  Lines          31776    31940      +164     
  Branches        2636     2643        +7     
==============================================
- Hits           15953     9438     -6515     
- Misses         14888    21722     +6834     
+ Partials         935      780      -155     
Impacted Files Coverage Δ
...mmons/crypto/exception/AesDecryptionException.java 0.00% <0.00%> (ø)
...mmons/crypto/exception/AesEncryptionException.java 0.00% <0.00%> (ø)
...xception/AlgorihmNotAvailableRuntimeException.java 0.00% <0.00%> (ø)
...pua/commons/crypto/exception/CryptoErrorCodes.java 0.00% <0.00%> (ø)
...apua/commons/crypto/exception/CryptoException.java 0.00% <0.00%> (ø)
...mmons/crypto/exception/CryptoRuntimeException.java 0.00% <0.00%> (ø)
...tion/DefaultSecretKeyDetectedRuntimeException.java 0.00% <0.00%> (ø)
...to/exception/InvalidSecretKeyRuntimeException.java 0.00% <0.00%> (ø)
...sticsearch/client/AbstractElasticsearchClient.java 0.00% <ø> (ø)
...ticsearch/client/rest/RestElasticsearchClient.java 60.77% <0.00%> (-1.10%) ⬇️
... and 535 more

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels Jul 12, 2022
@Coduz Coduz merged commit f25db7a into eclipse:develop Jul 12, 2022
@MDeLuise MDeLuise deleted the fix/password-change-special-chars branch October 22, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console
Projects
Development

Successfully merging this pull request may close these issues.

Password update encoding
2 participants