Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML completion based on external DTD #106

Closed
angelozerr opened this issue Sep 8, 2018 · 11 comments
Closed

XML completion based on external DTD #106

angelozerr opened this issue Sep 8, 2018 · 11 comments
Assignees
@angelozerr
Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request
Milestone
v0.3.0

Comments

@angelozerr
Copy link
Contributor

No description provided.

@NikolasKomonen NikolasKomonen self-assigned this Sep 10, 2018
@NikolasKomonen
Copy link
Contributor

@angelozerr Already working on it, almost done.

@angelozerr
Copy link
Contributor Author

@angelozerr Already working on it, almost done.

Really? You are implementing CMDocument like XML Schema, is that?

@NikolasKomonen
Copy link
Contributor

Oh sorry, I got this confused. I'm not working on this.

@NikolasKomonen NikolasKomonen removed their assignment Sep 10, 2018
@fbricon fbricon added enhancement New feature or request completion This issue or enhancement is related to completion support labels Sep 12, 2018
@fbricon fbricon added the to do label Sep 25, 2018
@fbricon
Copy link
Contributor

fbricon commented Nov 13, 2018

@NikolasKomonen what's the status on that one? Can we target 0.0.3?

@fbricon fbricon added the DTD label Nov 13, 2018
@angelozerr
Copy link
Contributor Author

@fbricon I'm not sure that @NikolasKomonen is working on that, but if you think it's very important I could work on it.

@fbricon
Copy link
Contributor

fbricon commented Nov 13, 2018

Having full Schema and DTD support would pretty much complete the validation stories. The rest is icing on the cake ;-)

@angelozerr
Copy link
Contributor Author

Ok I will work on it.

@angelozerr angelozerr self-assigned this Nov 13, 2018
@fbricon
Copy link
Contributor

fbricon commented Nov 13, 2018

thanks @angelozerr!

@angelozerr angelozerr added this to the v0.0.3 milestone Nov 14, 2018
@angelozerr angelozerr mentioned this issue Nov 14, 2018
Closed
angelozerr added a commit that referenced this issue Nov 14, 2018
@angelozerr
Initialize DTD document model (see #106)
ce0240b
angelozerr added a commit that referenced this issue Nov 14, 2018
@angelozerr
Fix ava.net.MalformedURLException when internal DTD (see #106)
266bc2f
angelozerr added a commit that referenced this issue Nov 16, 2018
@angelozerr
Use DocumentType#getSystemId() (see #106)
accc4ce
@angelozerr angelozerr changed the title DTD support for completion XML completion based on DTD Nov 20, 2018
angelozerr added a commit that referenced this issue Nov 20, 2018
@angelozerr
Implement XML completion based on DTD for element (see #106)
03183c2 
Signed-off-by: angelozerr <[email protected]>
@angelozerr
Copy link
Contributor Author

@fbricon it should starts working (only completion for element and based on external DTD).

I will work for other features like completion on attribute, internal DTD (declared in the XML)

@angelozerr angelozerr removed the to do label Dec 3, 2018
angelozerr added a commit that referenced this issue Dec 3, 2018
@angelozerr
Support XML attributes completion based on DTD (see #106)
4bd33b3
@angelozerr
Copy link
Contributor Author

@fbricon completion for element and attributes based on external DTD should work (with tests too). For internal DTD it doesn't work yet. Should we create an another issue for that?

@fbricon
Copy link
Contributor

fbricon commented Dec 3, 2018

Ok, but then you should rename this one to clarify it's for external DTDs

@angelozerr angelozerr changed the title XML completion based on DTD XML completion based on external DTD Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen