Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a Windows PR verification job #1311

Closed
rgrunber opened this issue Oct 11, 2022 · 0 comments · Fixed by #1343
Closed

Consider adding a Windows PR verification job #1311

rgrunber opened this issue Oct 11, 2022 · 0 comments · Fixed by #1343
Assignees
Labels
Milestone

Comments

@rgrunber
Copy link
Contributor

Currently, https://github.com/eclipse/lemminx/blob/main/Jenkinsfile is used for PR verification, and snapshot builds at https://download.eclipse.org/lemminx/snapshots/ which runs on Linux agents only. It would be really nice to also run the PR verification on Windows. This isn't easy to do on Eclipse infrastructure, so we may have to consider doing this verification on GH actions.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

So the options here are :

1.Keep https://github.com/eclipse/lemminx/blob/main/Jenkinsfile as-is and just add a PR verification job on GH actions for Windows
2. Disable only the PR-verification aspect of https://github.com/eclipse/lemminx/blob/main/Jenkinsfile (https://ci.eclipse.org/lemminx/job/lemminx/) and do it all on GH actions (including Windows)
3. Migrate all of https://github.com/eclipse/lemminx/blob/main/Jenkinsfile to GH actions, which would mean deciding what to do with https://download.eclipse.org/lemminx/snapshots/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants