Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify pull requests on windows with github actions #1343

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Verify pull requests on windows with github actions #1343

merged 1 commit into from
Oct 26, 2022

Conversation

JessicaJHee
Copy link
Contributor

Fixes #1311

Signed-off-by: Jessica He [email protected]

@datho7561
Copy link
Contributor

Once you address Roland's feedback, I think it's good to merge.

rgrunber
rgrunber approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after the tests pass. I think this should address things. I would just verify afterwards that the Jenkins build either stops showing the "PR" tab or that it no longer triggers on pull requests.

@JessicaJHee JessicaJHee merged commit 24ff745 into eclipse:main Oct 26, 2022
@JessicaJHee JessicaJHee deleted the pr-verify-gh branch October 26, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding a Windows PR verification job
3 participants
@JessicaJHee @datho7561 @rgrunber