-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surround with tags fails when there is no root element #1395
Comments
It also seems to fail if the cursor is outside of the root element |
I think this issue is when you are using file association, no? If you create a file without file association (without grammar linked), have you this issue? |
I'll double check... |
Yes, you are right. It only happens when the xml is associated with a grammar through a file association. |
datho7561
added a commit
to datho7561/lemminx
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes eclipse#1395 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/lemminx
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes eclipse#1395 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/lemminx
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes eclipse#1395 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/lemminx
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes eclipse#1395 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/lemminx
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes eclipse#1395 Signed-off-by: David Thompson <[email protected]>
angelozerr
pushed a commit
that referenced
this issue
Dec 8, 2022
- Fill in grammar when invoking surround tag in an empty document - Fix NPE that prevented surround tags from working in empty documents that are linked to a grammar with file association Closes #1395 Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
eg.
Trigger surround with tags at the
|
. (You can also reproduce the issue in an empty file).In the logs, I get:
The text was updated successfully, but these errors were encountered: