Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRenameParticipant.doRename() is not conform with LSP-defined rename result #1521

Closed
vrubezhny opened this issue May 31, 2023 · 0 comments · Fixed by #1522
Closed

IRenameParticipant.doRename() is not conform with LSP-defined rename result #1521

vrubezhny opened this issue May 31, 2023 · 0 comments · Fixed by #1522
Assignees
@vrubezhny
Labels
code action debt This issue or enhancement is related to technical debt
Milestone
0.26.0

Comments

@vrubezhny
Copy link
Contributor

vrubezhny commented May 31, 2023 •
edited
Loading

Currently the IRenameParticipant.doRename() allows the only TextEdit objects to be collected, thus not allowing the return the result of rename operation for multiple workspace documents.

LSP says:

result: WorkspaceEdit | null describing the modification to the workspace. null should be treated the same was as WorkspaceEdit with no changes (no change was required).

So, rename operation on multiple documents, in theory, is possible, but currently we're limited to only one document to be processed.

To make it possible to rename in multiple documents the IRenameParticipant.doRename() must allow collecting the list of TextDocumentEdit objects that later is to be used when creating the WorkspaceEdit result.

Required for Rename Maven properties support - eclipse/lemminx-maven#383
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 1, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
9f3f633 
…result eclipse#1521
@vrubezhny vrubezhny mentioned this issue Jun 1, 2023
Merged
@vrubezhny vrubezhny linked a pull request Jun 1, 2023 that will close this issue
IRenameParticipant.doRename() is not conform with LSP-defined rename … #1522
Merged
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 1, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
9229499 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 1, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
3f40e5f 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 10, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
5ce9d60 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 10, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
daaa002 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 10, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
f7b3e72 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 10, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
381a806 
…result eclipse#1521
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Jun 10, 2023
@vrubezhny
IRenameParticipant.doRename() is not conform with LSP-defined rename …
49fe6f7 
…result eclipse#1521
@angelozerr angelozerr added this to the 1.0.0 milestone Jun 10, 2023
@angelozerr angelozerr added debt This issue or enhancement is related to technical debt code action labels Jun 10, 2023
angelozerr pushed a commit that referenced this issue Jun 10, 2023
@vrubezhny @angelozerr
IRenameParticipant.doRename() is not conform with LSP-defined rename …
63c9a75 
…result #1521
@vrubezhny vrubezhny modified the milestones: 1.0.0, 0.26.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
code action debt This issue or enhancement is related to technical debt
Projects
None yet
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

IRenameParticipant.doRename() is not conform with LSP-defined rename … vrubezhny/lemminx
2 participants
@vrubezhny @angelozerr