Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeAction for MarkupEntityMismatch #588

Closed
angelozerr opened this issue Oct 29, 2019 · 0 comments · Fixed by #595 or enxio/lsp4xml#13
Closed

CodeAction for MarkupEntityMismatch #588

angelozerr opened this issue Oct 29, 2019 · 0 comments · Fixed by #595 or enxio/lsp4xml#13
Assignees
@NikolasKomonen
Labels
code action enhancement New feature or request XSD
Milestone
v0.9.2

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Oct 29, 2019 •
edited
Loading

Given this XML

<project xmlns="http://maven.apache.org/POM/4.0.0" 
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

image

A code action should close the project root element by inserting

</project>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 15, 2019
@NikolasKomonen
CodeACtion for missiing root end tag
6bca0c1 
Fixes eclipse#588

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Nov 15, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 15, 2019
@NikolasKomonen
CodeAction for missing root end tag
e026c08 
Fixes eclipse#588

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 22, 2019
@NikolasKomonen
CodeAction for missing end tag
e7aa564 
Creates a code action for both MarkupEntityMismatch and ETagRequired errors

Fixes eclipse#588

Signed-off-by: Nikolas Komonen <[email protected]>
@angelozerr angelozerr added the enhancement New feature or request label Nov 22, 2019
@angelozerr angelozerr added this to the v0.9.2 milestone Nov 22, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 25, 2019
@NikolasKomonen
CodeAction for missing end tag
b69f2e1 
Creates a code action for both MarkupEntityMismatch and ETagRequired errors

Fixes eclipse#588

Signed-off-by: Nikolas Komonen <[email protected]>
angelozerr pushed a commit that referenced this issue Nov 25, 2019
@NikolasKomonen @angelozerr
CodeAction for missing end tag
5606fa7 
Creates a code action for both MarkupEntityMismatch and ETagRequired errors

Fixes #588

Signed-off-by: Nikolas Komonen <[email protected]>
@enxio enxio mentioned this issue Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
code action enhancement New feature or request XSD
Projects
None yet
Milestone
v0.9.2
2 participants
@angelozerr @NikolasKomonen