Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No hyperlink to DTD source on hover #693

Closed
fbricon opened this issue May 12, 2020 · 0 comments · Fixed by #695
Closed

No hyperlink to DTD source on hover #693

fbricon opened this issue May 12, 2020 · 0 comments · Fixed by #695
Assignees
@angelozerr
Labels
DTD enhancement New feature or request
Milestone
0.12.0

Comments

@fbricon
Copy link
Contributor

fbricon commented May 12, 2020

Given this web.xml:

<!DOCTYPE web-app PUBLIC
 "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
 "http://java.sun.com/dtd/web-app_2_3.dtd" >

<web-app>
  <display-name>Servlet 2.3 Web Application</display-name>
</web-app>

Source hyperlink to web-app_2_3.dtd is missing. It only seems to work for xsd schemas.

Screen Shot 2020-05-12 at 8 12 58 PM
@fbricon fbricon added enhancement New feature or request DTD labels May 12, 2020
@fbricon fbricon added this to the 0.12.0 milestone May 12, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 12, 2020
@angelozerr
No hyperlink to DTD source on hover
bafff28 
Fixes eclipse#693

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 13, 2020
@angelozerr
No hyperlink to DTD source on hover
31e5fae 
Fixes eclipse#693

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue May 13, 2020
Merged
@angelozerr angelozerr self-assigned this May 13, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 13, 2020
@angelozerr
No hyperlink to DTD source on hover
836e6ed 
Fixes eclipse#693

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit that referenced this issue May 13, 2020
@angelozerr @fbricon
No hyperlink to DTD source on hover
9beabb5 
Fixes #693

Signed-off-by: azerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
DTD enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

No hyperlink to DTD source on hover angelozerr/lemminx
2 participants
@fbricon @angelozerr