Added closingBracketNewLine option

[AlexXuChen]

Added formatting option to put XML closing tagbracket on newline.

Closes redhat-developer/vscode-xml#435

Signed-off-by: Alexander Chen [email protected]

[AlexXuChen]

test this please

[datho7561]

test this please

[AlexXuChen]

Changes to package.json on vscode-xml: redhat-developer/vscode-xml/pull/508

[datho7561]

Here's a case that isn't working as expected:

<aaa>
  <bbb attr1="value" attr2="value" />
</aaa>

When you format with the setting enabled, you would expect the end of the tag /> to be indented to the same level as the start of the tag <bbb. Instead, you get:

<aaa>
  <bbb
      attr1="value"
      attr2="value"
/>
</aaa>

It would be good to fix this case, and add a unit test for it.

[AlexXuChen]

Another small clarification about behaviour, similar to your comment:

if we have:

<aaa>
  <bbb attr1="value" attr2="value">
  </bbb>
</aaa>

along with the previous issue, when formatted, it becomes:

<aaa>
  <bbb 
    attr1="value" 
    attr2="value" 
></bbb>
</aaa>

So not only does the indenting not follow, but the closing bracket is on the same line as the closing tag.

Should this be fixed with my feature, or is this a part of another formatting setting?

*Edit - is this bug related? redhat-developer/vscode-xml/issues/505

**Edit - by enabling preserveEmptyContent, this issue no longer happens. However, the code action bug i see with redhat-developer/vscode-xml/issues/505 remains, even with preserveEmptyContent

[datho7561]

Should this be fixed with my feature, or is this a part of another formatting setting?

Except for the fact that the > isn't indented properly, this appears to be working as intended. The formatter intentionally removes the white space between the opening and closing tag. If you enable xml.format.preserveEmptyContent, it should keep the white space. If you set xml.format.emptyElements to collapse, it will replace ></bbb> with />

[datho7561]

Its working really well, just needs a small improvement in the documentation