Improved accuracy of attribute value quick fix suggestions #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Dec 10, 2021
...ipse/lemminx/extensions/contentmodel/participants/codeactions/cvc_attribute_3CodeAction.java
Outdated
Show resolved
Hide resolved
AlexXuChen
force-pushed
the
issue618-xml
branch
2 times, most recently
from
b6240ae
to
45cfcf9
Compare
rgrunber
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
LGTM and works as expected. I don't see any similar tests for code actions, so I guess this should be fine.
@angelozerr , let me know if this can be merged.
...ipse/lemminx/extensions/contentmodel/participants/codeactions/cvc_attribute_3CodeAction.java
Outdated
Show resolved
Hide resolved
AlexXuChen
force-pushed
the
issue618-xml
branch
from
45cfcf9
to
695780f
Compare
Merged
|
It should be nice to write tests for this feature. We have already test for similar with local name at I suggest you write a test with similar for attribute (see tests which defines attribute enumeration by searching cvc_attribute_3 in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/XMLSchemaDiagnosticsTest.java |
AlexXuChen
force-pushed
the
issue618-xml
branch
from
695780f
to
5e622f1
Compare
AlexXuChen
commented
Dec 13, 2021
...minx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/XMLSchemaDiagnosticsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Chen <[email protected]>
AlexXuChen
force-pushed
the
issue618-xml
branch
from
5e622f1
to
3fe24bf
Compare
|
Thanks @AlexXuChen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved accuracy of attribute value Quick Fix suggestions.
Fixes redhat-developer/vscode-xml/issues/618
Signed-off-by: Alexander Chen [email protected]