Wait a bit after change before sending diagnostics

[angelozerr]

Wait a bit after change before sending diagnostics

Fixes #1162

Signed-off-by: azerr [email protected]

[angelozerr]

This PR publish diagnostics with 200ms as delay.

Here a demo with vscode-xml and linked edting range:

.

Instead of reporting a diagnostics per typed character, it generate few diagnotics.

[angelozerr]

@vrubezhny could you review too this PR and tell me if it improves performance for Eclipse IDE with WWD please.

[AlexXuChen]

The delay is working as described, however, perhaps we can optimize diagnostic reporting further by only sending the affected diagnostic in the response (i.e. if there are 2 diagnostics in 2 separate files in the workspace, and one diagnostic is changed, the other still sends a publishDiagnostics response)

[angelozerr]

When you say affected diagnostic you mean the document which is updating?

If it that the report of the diagnostic is just for the updated document.

But if you save the document in this case the server will report diagnostics for all opened document. Perhaps it is tour usecase

[AlexXuChen]

But if you save the document in this case the server will report diagnostics for all opened document. Perhaps it is tour usecase

Yes, I update the diagnostic by saving, so all diagnostics are reported again.

[angelozerr]

Yes, I update the diagnostic by saving, so all diagnostics are reported again.

It is the expected behvior. This PR provides delay for reporting diagnostic when document changed. When document it is saved, there is no delay and I think it is not annoying to report diagnostics for all opened files just on save.

The problem is when you change document, you must try to report few diagnotics to improve :

• performance on XML languagse server side. if user type N characters, in master it validate N times and report N diagnostics. With this PR if user type N characters, it should validate one time and report one diagnotic
• performance on LSP client side.

[angelozerr]

Thanks @fbricon @AlexXuChen for your review!