Suppress validation kinds based on file pattern

[angelozerr]

Suppress validation kinds based on file pattern

Fixes #1275

Signed-off-by: azerr [email protected]

[angelozerr]

It starts working. If you add in your settings.json

"xml.validation.filters": [
      {
         "pattern": "**.exsd",
         "enabled": false
      },
      {
         "pattern": "**{.project,.classpath,plugin.xml,feature.xml}",
         "noGrammar": "ignore"
      }
   ]

But if you don't set this settings (not validation filter settings), LemMinx will use internally this default settings.

It should disable validation for exsd files, and disable the noGrammar hint for plugin.xml, .classpath, .project files.

I have not managed severity for error code because we don't need it for the moment.

The main idea that I implemented is that you can define all validation settings (xml.validation.enabled, xml.validation.noGrammar, etc) see https://github.com/redhat-developer/vscode-xml/blob/main/docs/Validation.md that we have for a given pattern.

For instance by default we have:

xml.validation.noGrammar : "hint" which display an information on root tag element which says that there are no grammar. It is a global validation settings.

For plugin.xml we don't want this "hint", so you can write a filter like this:

{
    "pattern": "plugin.xml",
    "noGrammar": "ignore"
 },

Here the result:

No I need to define this settings by default on LemMinX side

[angelozerr]

@merks here the default validation filter that LemMinX will use by default. Do you see another filter which should be done for other files?

[merks]

Thanks for asking. With PDE there are also *.product files (root element ) for defining products, *.target files (root element ) for defining target platforms, and category.xml (root element ) for defining update sites.

[angelozerr]

Thanks for asking. With PDE there are also *.product files (root element ) for defining products, *.target files (root element ) for defining target platforms, and category.xml (root element ) for defining update sites.

Oh yes you are right, thanks for your feedback. I add those 3 file patterns. Thanks!

[angelozerr]

@datho7561 please see too the vscode-xml PR redhat-developer/vscode-xml#774 which provides this new validation filter setting.

[angelozerr]

@merks I have tested quickly with WWD and my PR and I can confirm that it works: You will benefit with No grammar constraints for other XML files and not for plugin.xml for instance:

and you will continue to benefit with XML syntax validation from LemMinX in plugin.xml:

[merks]

@angelozerr Thanks! And also thanks from the uncounted users!!

[datho7561]

Works well. I also tried out the binary using neovim (so the lemminx settings use the defaults), and it works properly there as well. There we a few things I noticed in the code, and once they are addressed I think it should be good to merge.

[angelozerr]

Works well. I also tried out the binary using neovim (so the lemminx settings use the defaults), and it works properly there as well. There we a few things I noticed in the code, and once they are addressed I think it should be good to merge.

To be consistent with symbol filter, I add it those XML validation filter classes in reflect-config.json

[datho7561]

Thank you, Angelo!