Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prolog completion calculates completion for every character typed #162

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Prolog completion calculates completion for every character typed #162

merged 1 commit into from
Oct 18, 2018

Conversation

NikolasKomonen
Copy link
Contributor

Fixes #85

@fbricon
Copy link
Contributor

fbricon commented Oct 12, 2018

With <?xml| ?>, autocompletion doesn't take closing ?> into account:

oct-12-2018 16-49-47

You might want to rebase and squash your PR

@angelozerr
Copy link
Contributor

angelozerr commented Oct 15, 2018 •
edited
Loading

With , autocompletion doesn't take closing ?> into account:

@NikolasKomonen I suggest you to use isFollowedBy like I'm using for generator or not close tag > in https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/XMLCompletions.java#L418

@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

fbricon
fbricon reviewed Oct 17, 2018
View reviewed changes
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/XMLCompletions.java Outdated
case PIName: {
try {

String tagName = scanner.getTokenText();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable (your IDE should warn you about it)

@fbricon
Copy link
Contributor

fbricon commented Oct 18, 2018

Works well enough for now, so +1 to merge.
However I found a problem with completing partial prologs, will open a separate ticket.

@fbricon fbricon merged commit 326fa9e into eclipse:master Oct 18, 2018
@NikolasKomonen NikolasKomonen deleted the prologFix branch January 22, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasKomonen @fbricon @angelozerr