-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTD Formatting implemented #274
Conversation
94a6571
to
d6b09b3
Compare
With this PR, the DTD from #268 (comment) is broken after formatting. it changes The plus sign should stick to the closing parenthesis |
@fbricon Thanks, this was the one I forgot to finish. |
93a3dbe
to
a326846
Compare
<!ATTLIST img
src CDATA #REQUIRED
alt CDATA #IMPLIED
height CDATA #IMPLIED
width CDATA #IMPLIED
align CDATA #IMPLIED
border CDATA #IMPLIED
hspace CDATA #IMPLIED
vspace CDATA #IMPLIED
%all;>
<!-- Hypertext anchors.
CONSTRAINT: A elements are not allowed inside
other A elements, a fact that XML cannot express. --> is turned into
the closing bracket disappears. Also, there's an extra space added in front of each attribute. |
a326846
to
ecec44c
Compare
@fbricon Updated |
ecec44c
to
c366db1
Compare
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/XMLFormatter.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/services/XMLFormatter.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
d0fcb67
to
88c5d0e
Compare
Fixes eclipse#221 and eclipse#268 Signed-off-by: Nikolas Komonen <[email protected]>
88c5d0e
to
a45fa00
Compare
@fbricon tested again with dtds, all looks good. |
Fixes #221, #250, #268, #226