Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTD Error Ranges Adjusted #278

Merged
merged 1 commit into from
Jan 21, 2019
Merged

DTD Error Ranges Adjusted #278

merged 1 commit into from
Jan 21, 2019

Conversation

NikolasKomonen
Copy link
Contributor

@NikolasKomonen NikolasKomonen commented Jan 11, 2019 •
edited
Loading

Fixes #225

@NikolasKomonen
Copy link
Contributor Author

@fbricon let me know your thoughts on the ranges.

@NikolasKomonen NikolasKomonen changed the title DTD Formatting implemented DTD Error Ranges Adjusted Jan 11, 2019
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

@NikolasKomonen
Copy link
Contributor Author

@fbricon updated with tests

@fbricon
Copy link
Contributor

fbricon commented Jan 17, 2019

Putting it here too:

wrong ranges for

  • MSG_ELEMENT_ALREADY_DECLARED (duplicate <!ELEMENT Email (#PCDATA)> )
  • wrong range for PEReferenceWithinMarkup, see:
<!DOCTYPE Folks [
  <!ENTITY % Folks "(%bar;)*">
]>

@NikolasKomonen
DTD Error Ranges Adjusted
39dac91 
Fixes eclipse#225

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated to cover new cases

@fbricon fbricon merged commit 60e9e34 into eclipse:master Jan 21, 2019
@NikolasKomonen NikolasKomonen deleted the dtdRanges branch March 7, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasKomonen @fbricon