Fixed EOF Error #332
Merged
Fixed EOF Error #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unit test? |
NikolasKomonen
force-pushed
the
prematureEOFError
branch
from
143d2d8
to
8e2d63d
Compare
|
I'd expect an error to be raised to the user. When only the xml prolog is present in a file, Intellij shows: "Valid XML document should have a root tag". |
fbricon
requested changes
Mar 18, 2019
...4xml/src/test/java/org/eclipse/lsp4xml/extensions/contentmodel/XMLSchemaDiagnosticsTest.java
Show resolved
Hide resolved
Fixes eclipse#157 The most common ocurrences of this error are when the document is empty or there is just the xml prolog (<?xml ... ?>). Errors that give negative values will be ignored for now. Signed-off-by: Nikolas <[email protected]>
NikolasKomonen
force-pushed
the
prematureEOFError
branch
from
8e2d63d
to
fcfc71a
Compare
|
@fbricon fixed the unit test names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
The most common ocurrences of this error are
when the document is empty or there is just the
xml prolog (
<?xml ... ?>). All errors that give negative valueswill be ignored for now.
Signed-off-by: Nikolas [email protected]