Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store the owner document instance in each nodes. #393

Merged
merged 1 commit into from
May 27, 2019

Conversation

angelozerr
Copy link
Contributor

Don't store the owner document instance in each nodes (see #389). This PR improves the memory with big file (there is around 1GB gain with nasa.xml file)

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

Here the result when nasa.xml is parsed with DOM Parser with existing code:

image

Here the result when nasa.xml is parsed with DOM Parser with this PR (owner document is not stored in each nodes instances):

image

There is around 1GB of gain.

@fbricon fbricon merged commit 12e3956 into master May 27, 2019
@angelozerr angelozerr deleted the memory-owner-document branch May 28, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants