Use CompletableFuture to load DOMDocument #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #439
This PR uses CompletableFuture to load DOMDocument. The basic idea is when a service is called (ex: foldingRanges) it load DOM document if it need and then execute foldingRanges compute.
It's more cleaner than using a synchronized keyword. This PR remove the language model cache (which stored the DOMDocument in a map) and now the ModelTextDocument (which extends TextDocument) provides a getModel which returns the completable future which load the DOM document.
This PR should improve the stop of parse of DOM document which is done when requets is canceled (by client) or when text document version changed.