Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSG_ATTRIBUTE_NOT_DECLARED must highlight attribute name instead of attribute value #634

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

angelozerr
Copy link
Contributor

MSG_ATTRIBUTE_NOT_DECLARED must highlight attribute name instead of attribute value.

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

angelozerr commented Apr 14, 2020

Given this XML file:

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE note [
	<!ELEMENT note (to,from,heading,body, note?)>
	<!ATTLIST note version CDATA #REQUIRED>

]>
<note XXXXXX="0.9.0" >  
</note>

XXXXXX attribute name should be highlighted as error. In master it's the XXXXXX attribute value ("0.9.0") which is highlighted which is wrong.

@angelozerr angelozerr requested a review from fbricon April 14, 2020 10:07
@angelozerr angelozerr self-assigned this Apr 14, 2020
@angelozerr angelozerr added bug Something isn't working validation DTD labels Apr 14, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone Apr 14, 2020
@xorye
Copy link

xorye commented Apr 14, 2020

I have tested this PR, this PR can be merged

@angelozerr angelozerr merged commit 24aee91 into eclipse:master Apr 14, 2020
@angelozerr
Copy link
Contributor Author

Thanks @xorye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DTD validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants