Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion & hover based on XSD with elementFormDefault="unqualified" #855

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

angelozerr
Copy link
Contributor

Fix completion & hover based on XSD with elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

To test this PR:

  • open foo-qualified.xml which is in this PR
  • open completion after bar, you should see item (the fix).

or try the user usecase redhat-developer/vscode-xml#311 (comment)

@datho7561
Copy link
Contributor

For the user use case, I tried deleting <subtitle></subtitle> element, and then opening completion. It is specified as min 0 max 1, but it isn't suggested. If I open completion after <subtitle></subtitle>, it suggests adding another subtitle element:
SubtitleDoesntAppearUntilAfter

@angelozerr
Copy link
Contributor Author

@datho7561 have you configured the XML catalog?

@datho7561
Copy link
Contributor

@datho7561 have you configured the XML catalog?

Thanks oops.

@datho7561
Copy link
Contributor

I configured the catalog, and now it works for the root level, but not nested elements:

NestedStillDoesntWork

@angelozerr
Copy link
Contributor Author

I configured the catalog, and now it works for the root level, but not nested elements:

Indeed there were a problem with XML catalog. Please retry it.

elementFormDefault="unqualified"

See redhat-developer/vscode-xml#311

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr merged commit a3a043b into eclipse:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants