Wrap extensions with try/catch and log exceptions #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests |
angelozerr
reviewed
Dec 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLDiagnostics.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Dec 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLDocumentLink.java
Outdated
Show resolved
Hide resolved
Your PR looks very good. For writting test I suggest you create a test class for that like ErrorParticipantLanguageServiceTest (like SymbolsProviderParticipantTest) which defines an internal class ErrorParticipantLanguageService which extends XMLLanguageService and register for each support (completion, diagnostics, etc) a participant which throw an error. After that you write a test per feature which test completion and which should return some result instead of stopping everything. |
datho7561
force-pushed
the
946-catch-and-log-extension-exceptions
branch
2 times, most recently
from
f55935e
to
19b8919
Compare
angelozerr
reviewed
Dec 16, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Dec 16, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLRename.java
Outdated
Show resolved
Hide resolved
datho7561
commented
Dec 16, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLSymbolsProvider.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Dec 16, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/XMLBuilder.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
946-catch-and-log-extension-exceptions
branch
from
19b8919
to
2bfb29a
Compare
angelozerr
reviewed
Dec 17, 2020
...c/test/java/org/eclipse/lemminx/services/extensions/ErrorParticipantLanguageServiceTest.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Dec 17, 2020
...c/test/java/org/eclipse/lemminx/services/extensions/ErrorParticipantLanguageServiceTest.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Dec 17, 2020
...c/test/java/org/eclipse/lemminx/services/extensions/ErrorParticipantLanguageServiceTest.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
946-catch-and-log-extension-exceptions
branch
from
2bfb29a
to
f8b188a
Compare
Fixes eclipse#946 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
946-catch-and-log-extension-exceptions
branch
from
f8b188a
to
f56b9e4
Compare
|
Nice job @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946
Signed-off-by: David Thompson [email protected]