perf: improve StreamProxyInputStream #1068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current implementation is sub optimal as it creates a new queue element for each byte read from the process.
the new implementation queues arrays of bytes instead, resulting in fewer queue elements and in avoiding
byte -> Byte -> byte
conversions. this also reduces GC pressure in the Eclipse IDE process.I also implemented
read(final byte[] buf, final int off, final int len)
which improves bulk read performance.