Add hide fields toolbar button to outline view (fix #1073) #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
reviewed
Aug 23, 2024
org.eclipse.lsp4e/src/org/eclipse/lsp4e/outline/ToggleHideFieldsOutlineHandler.java
Show resolved
Hide resolved
travkin79
force-pushed
the
patch-issue-1073
branch
3 times, most recently
from
5263875
to
42b1d08
Compare
This was referenced Aug 29, 2024
travkin79
force-pushed
the
patch-issue-1073
branch
2 times, most recently
from
ff90685
to
2d20fd0
Compare
travkin79
force-pushed
the
patch-issue-1073
branch
from
2d20fd0
to
d909d7b
Compare
|
@travkin79 , shall I merge it now once the checks pass? |
|
Thank you @rubenporras |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rubenporras,
I'm working on the "hide fields" toolbar entry in the outline view and it works already.
Nevertheless, I think, I need to improve the implementation. I'd like to improve how the states of the menu entry "Hide..." -> "Field" and the toolbar entry "Hide Fields" are synchronized in the outline view. Currently I let the Hide Fields handler register for preference changes and do update the command's state. Do you have a better solution for that?
Besides, I observe some strange behavior in the outline view. As soon as the outline looses focus (by clicking into the CDT LSP editor in my case), the sort and hide fields buttons disappear. I observed that already before preparing my PR with the sort toolbar entry. I'm not sure if this is going wrong in LSP4E or in CDT LSP. Can you observe the same issue?
Another minor issue is that the toolbar buttons icon look different to the icon used in the menu entry "Hide..." > "Field" (and other places). But I could live with that for now.
Thanks and best regards.