feat: introduce LanguageServerWrapper#getServerCapabilitiesAsync #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
reviewed
Sep 4, 2024
org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/inlayhint/LSPLineContentCodeMining.java
Show resolved
Hide resolved
|
Other than my comment, the PR is a very nice idea. |
sebthom
force-pushed
the
server-caps-async
branch
from
957db1c
to
c3cec9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getServerCapabilities()can block for up to 10 seconds. In code locations where the result is a future anyways it is useful to have agetServerCapabilitiesAsync()I am planning to use
getServerCapabilitiesAsync()more in future PRs where it will play nicely with the then suggested changes.Addresses #628