Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing to inline type hints. Fixes #981 #982

Merged
merged 1 commit into from
May 6, 2024

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented May 3, 2024

Adds a space separator between the inline type hint and the variable name.

Before this PR:
image

After this PR:
image

This is similar to what JDT does:
https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/6333016444d089418d28a0e5e331ae3545030d82/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/codemining/JavaMethodParameterCodeMining.java#L31

@sebthom sebthom requested a review from rubenporras May 3, 2024 21:20
@mickaelistria mickaelistria merged commit d3d25c0 into eclipse:master May 6, 2024
2 checks passed
@sebthom sebthom deleted the inline-type-hints branch May 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants