Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for @Startup healthcheck diagnostic #443

Closed
michelcouto opened this issue Apr 15, 2024 · 2 comments · Fixed by #453
Closed

Add support for @Startup healthcheck diagnostic #443

michelcouto opened this issue Apr 15, 2024 · 2 comments · Fixed by #453
Assignees
@angelozerr
Labels
code action enhancement New feature or request validation
Milestone
0.12.0

Comments

@michelcouto
Copy link

When having a class implementing org.eclipse.microprofile.health.HealthCheck and using the @Startup annotation brought since 3.1 API, Eclipse shows the following warning:
The class com.acme.SomeStartupHealthCheck implementing the HealthCheck interface should use the @Liveness or @Readiness annotation.

@Startup should also be supported!
@fbricon
Copy link
Contributor

fbricon commented Apr 15, 2024

Can you provide some pointers to the spec?

@michelcouto
Copy link
Author

michelcouto commented Apr 15, 2024 •
edited
Loading

Sure.
https://download.eclipse.org/microprofile/microprofile-health-3.1/apidocs/

See that, since 3.1, alongside Readiness and Liveness annotations, supported by the MicroProfile Language Server, there is then the Startup one as well.

https://github.com/eclipse/microprofile-health
In here, there are descriptions about the 3 different checks (startup, live and ready).

@fbricon fbricon mentioned this issue Apr 30, 2024
Merged
@angelozerr angelozerr changed the title MicroProfile - HealthCheck warning Add support for @Startup healthcheck diagnostic Jul 11, 2024
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Jul 11, 2024
@angelozerr
feat: Add support for @startup healthcheck diagnostic
bde016e 
Fixes eclipse#443

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lsp4mp that referenced this issue Jul 11, 2024
@angelozerr
feat: Add support for @startup healthcheck diagnostic
c5ff7f1 
Fixes eclipse#443

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jul 11, 2024
Merged
angelozerr added a commit that referenced this issue Jul 11, 2024
@angelozerr
feat: Add support for @startup healthcheck diagnostic
81bc31b 
Fixes #443

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr self-assigned this Jul 11, 2024
@angelozerr angelozerr added this to the 0.12.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
code action enhancement New feature or request validation
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

feat: Add support for @Startup healthcheck diagnostic angelozerr/lsp4mp
3 participants
@fbricon @angelozerr @michelcouto