Use template to determine jakarta namespace in snippets #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
added a commit
to datho7561/vscode-microprofile
that referenced
this pull request
Dec 9, 2022
See eclipse/lsp4mp#332 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
320-jakarta-snippets
branch
from
0acc431
to
2d6ad46
Compare
|
|
datho7561
force-pushed
the
320-jakarta-snippets
branch
from
2d6ad46
to
1f4ec24
Compare
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`
Closes eclipse#320, closes eclipse#229
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
320-jakarta-snippets
branch
from
1f4ec24
to
b3993d8
Compare
|
It works like a charm,thanks @datho7561 ! |
|
@kathrynkodama @yeekangc please at look at this merged PR, now we can support jakarta/javax namespace with the same snippet. |
|
@angelozerr @datho7561 thank you! This is excellent |
angelozerr
pushed a commit
to redhat-developer/vscode-microprofile
that referenced
this pull request
Jan 4, 2023
See eclipse/lsp4mp#332 Signed-off-by: David Thompson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${jakarta}to point to eitherjavaxorjakarta, depending on which is available, and preferingjakartajaxrctorest_classandjaxrmtorest_getCloses #320, closes #229
Signed-off-by: David Thompson [email protected]