#266 improve the spec to take in explicit trues #270
Conversation
Signed-off-by: Emily Jiang <[email protected]>
|
just spec change..... tck changes will come soon. |
| Fault Tolerance policies can be disabled with configuration at method level, class level or globally for all deployment. | ||
| Fault Tolerance policies can be disabled with configuration at method level, class level or globally for all deployment. If multiple configurations are specified, method-level configuration overrides class-level configuration, which then overrides global configuration. e.g. | ||
| * `com.acme.test.MyClient/methodA/CircuitBreaker/enabled=true` | ||
| * `com.acme.test.MyClient/CircuitBreaker/enabled=false` |
There was a problem hiding this comment.
This middle line doesn't make a lot of sense. It's valid but has no effect because CircuitBreaker is disabled globally.
I think the example would be clearer if this line was removed.
There was a problem hiding this comment.
Alternatively, change the example to be global=false (as is), class-level=true, method-level=false and the explanation should state that all circuit breakers in the app are disabled, only those in the class except the method methodA are enabled.
| Fault Tolerance policies can be disabled with configuration at method level, class level or globally for all deployment. | ||
| Fault Tolerance policies can be disabled with configuration at method level, class level or globally for all deployment. If multiple configurations are specified, method-level configuration overrides class-level configuration, which then overrides global configuration. e.g. | ||
| * `com.acme.test.MyClient/methodA/CircuitBreaker/enabled=true` | ||
| * `com.acme.test.MyClient/CircuitBreaker/enabled=false` |
There was a problem hiding this comment.
Alternatively, change the example to be global=false (as is), class-level=true, method-level=false and the explanation should state that all circuit breakers in the app are disabled, only those in the class except the method methodA are enabled.
| @@ -153,4 +158,4 @@ For instance the following config will disable bulkhead policy globally: | |||
|
|
|||
| Policy will be disabled everywhere ignoring existing policy annotations on methods and classes. | |||
|
|
|||
| If the above configurations patterns are used with another value than `false` (i.e. `<classname>/<methodname>/<annotation>/enabled=whatever`) non-portable behaviour results. | |||
| If the above configurations patterns are used with another value than `true` or `false` (i.e. `<classname>/<methodname>/<annotation>/enabled=whatever`) non-portable behaviour results. | |||
There was a problem hiding this comment.
Grammar: "other values than" instead of "another value than"
Signed-off-by: Emily Jiang [email protected]