Make InMemoryMetricReader not a bean #642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the metric test changes, I ran into an issue where the
InMemoryMetricReader
would not be registered correctly for the first test app. This turned out to be because Liberty was initializing OpenTelemetry before CDI was fully initialized.This could be true for other runtimes as well, so I think we need to make the
InMemoryMetricReader
not depend on CDI.I changed it to use a static singleton instance, which works in liberty, but I wasn't sure whether that would work for implementations using an embedded arquillian container. For this reason, I've also cleared the static instance when the reader is shut down, with the intention that each new app will get a new instance.