Make enterprise dependencies optional, so that it can be used on SE as well #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well Signed-off-by: Kai Kreuzer <[email protected]>
kaikreuzer
added a commit
to kaikreuzer/smarthome
that referenced
this pull request
Sep 7, 2018
Not using official 1.1.1 release, but a manually built 1.1.1-sp1 which contains eclipse/microprofile-metrics#286 Signed-off-by: Kai Kreuzer <[email protected]>
htreu
pushed a commit
to eclipse-archived/smarthome
that referenced
this pull request
Sep 7, 2018
Not using official 1.1.1 release, but a manually built 1.1.1-sp1 which contains eclipse/microprofile-metrics#286 Signed-off-by: Kai Kreuzer <[email protected]>
|
Tested changes on a Liberty server and no issues were found. |
|
Thank you @kaikreuzer See you in Ludwigsburg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to use microprofile-metrics in Eclipse SmartHome as well and trying to add it, I had to noticed that the manifest declares mandatory dependencies to
javaxpackages, which are not part of JavaSE.While these dependencies might be relevant at compile time of the project, I absolutely do not see any need for their presence at runtime; only the implementations might have those dependencies, but that should be left to them.
I'd therefore suggest to mark those dependencies as optional, which let's people easily use this API on a plain JavaSE as well.
Signed-off-by: Kai Kreuzer [email protected]