Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated javadoc and TCK to support @APIResponse on ExceptionMappers #414

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

EricWittmann
Copy link
Contributor

This is a fix for #404

… airlines test to cover ExceptionMapper annotations. Fixes eclipse#404
@EricWittmann
Copy link
Contributor Author

Note to @MikeEdgar - I already tested this with SmallRye master and it works without needing any change to SR.

Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@arthurdm arthurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @EricWittmann

btw - coincidence that this fixes issue #404 and you have chosen an example that returns code 404? 😄

@arthurdm arthurdm merged commit 6af4b2b into eclipse:master Mar 11, 2020
@FreifeldRoyi
Copy link

WOOHOO!

@EricWittmann
Copy link
Contributor Author

btw - coincidence that this fixes issue #404 and you have chosen an example that returns code 404? 😄

Coincidence, yes - but a happy one!

@EricWittmann EricWittmann deleted the issues/404 branch March 11, 2020 17:41
Azquelt pushed a commit to Azquelt/microprofile-open-api that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants