-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make naming of CodeGenerator variable consistent #5594
Comments
I would like to work on this. Can you please assign it to me? |
Thanks for your offer to help! |
Thankyou so much 🙂 A quick question. After renaming all the instances, should I build and test the whole project? |
Generally, it is a good practice to test your changes to the extent that you can on your own before making a pull request (for example, on x86 Linux). The community certainly understands that you can't test them on every platform and architecture combination. When you do make a PR (or any time that you push new commits), a Travis CI job will run automatically that will perform a build (x86 Linux only). Once a committer has reviewed your code, they will run a much broader set of sanity tests on all architectures the OpenJ9 community cares about that you will see in the "Checks" section of the PR. |
Made the names consistent and made a PR. |
This patch makes all instances of CodeGenerator variables from `codeGen` to `cg`. Issue: eclipse#5594 Signed-off-by: Prakhar Yadav <[email protected]>
Resolving CodeGenerator object allocation issue. `CodeGenerator *cg = cg()` to `CodeGenerator *cg = this->cg()` Issue: eclipse#5594 Signed-off-by: Prakhar Yadav <[email protected]>
Update SystemLinkageLinux.cpp line 409 `cg()` to `this->cg()` Issue: eclipse#5594 Signed-off-by: Prakhar Yadav <[email protected]>
This patch makes all instances of CodeGenerator variables from `codeGen` to `cg`, and resolves issues of object allocation by replacing `CodeGenerator *cg = cg()` to `CodeGenerator *cg = this->cg()` Issue: eclipse#5594 Signed-off-by: Prakhar Yadav <[email protected]>
As there has been no indication of progress on this issue I will un-assign it. I appreciate your offer to help the project. You are welcome to pick up this issue (if it is still open) or any other issue should you wish to contribute to Eclipse OMR in the future. |
@dylanjtuttle : please have a look at this |
Make naming of variables holding the TR::CodeGenerator object consistent by renaming variables named codeGen to cg Issue: eclipse#5594 Signed-off-by: Dylan Tuttle <[email protected]>
Make naming of variables holding the TR::CodeGenerator object consistent by renaming variables named codeGen to cg Closes: eclipse#5594 Signed-off-by: Dylan Tuttle <[email protected]>
Make naming of variables holding the TR::CodeGenerator object consistent by renaming variables named codeGen to cg Closes: eclipse#5594 Signed-off-by: Dylan Tuttle <[email protected]>
The overwhelmingly common short form for a variable to store the
TR::CodeGenerator
object iscg
(about 30000 instances). The next most common form iscodeGen
(about 400). We should use a single form for consistency and given the popularity ofcg
that should be the preferred name. Sweep through the OMR compiler and make that change.Here is a pipeline of greps to help find some of the places to change:
The text was updated successfully, but these errors were encountered: