Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64 macOS: OMR fvtest failures #6716

Closed
knn-k opened this issue Sep 21, 2022 · 13 comments
Closed

AArch64 macOS: OMR fvtest failures #6716

knn-k opened this issue Sep 21, 2022 · 13 comments

Comments

@knn-k
Copy link
Contributor

knn-k commented Sep 21, 2022

Many fvtest programs fail on AArch64 macOS as shown below.

% compilertest/compilertest 
[==========] Running 35 tests from 6 test cases.
[----------] Global test environment set-up.
zsh: segmentation fault  compilertest/compilertest

% compilertriltest/comptest 
[==========] Running 148793 tests from 166 test cases.
[----------] 6 tests from PtrTest
[----------] 6 tests from PtrTest (0 ms total)
(... snip ...)
[----------] 1 test from InvalidCommoningTest
zsh: segmentation fault  compilertriltest/comptest

% compilerunittest/compunittest 
[==========] Running 1939 tests from 79 test cases.
[----------] 16 tests from AbsVPValueTest
zsh: segmentation fault  compilerunittest/compunittest

% jitbuildertest/jitbuildertest 
[==========] Running 58 tests from 14 test cases.
[----------] Global test environment set-up.
[----------] 2 tests from selftest
zsh: segmentation fault  jitbuildertest/jitbuildertest

% porttest/omrporttest 
[==========] Running 245 tests from 21 test cases.
[----------] 1 test from PortInitializationTest
[----------] 1 test from PortInitializationTest (0 ms total)
(... snip ...)
[----------] 19 tests from PortVmemTest
	**Could not find 0x4000 bytes available with page size 0x4000
***Did not find enough memory available on system, not running test omrvmem_testReserveMemoryExStrictAddress
Some textSome textzsh: abort      porttest/omrporttest

@Akira1Saitoh
Copy link
Contributor

Akira1Saitoh commented Sep 27, 2022

#6731 improves compilerunittest and compilertriltest.

% ./fvtest/compilerunittest/compunittest
[==========] Running 1939 tests from 79 test cases.
[----------] 16 tests from AbsVPValueTest
[----------] 16 tests from AbsVPValueTest (7 ms total)

[----------] 4 tests from AbsOpStackTest
[----------] 4 tests from AbsOpStackTest (1 ms total)

...

[----------] 26 tests from INS2/ARM64MovVectorElementEncodingTest
[----------] 26 tests from INS2/ARM64MovVectorElementEncodingTest (1 ms total)

[==========] 1939 tests from 79 test cases ran. (118 ms total)
[  PASSED  ] 1939 tests.
[  ALL TESTS PASSED  ]

% ./fvtest/compilertriltest/comptest
[==========] Running 148793 tests from 166 test cases.
[----------] 6 tests from PtrTest
[----------] 6 tests from PtrTest (0 ms total)

[----------] 8 tests from TRTestCombineVectorTest
[----------] 8 tests from TRTestCombineVectorTest (0 ms total)

[----------] 8 tests from TRTestCombineBraceInitTest
[----------] 8 tests from TRTestCombineBraceInitTest (0 ms total)

*** VALIDATION ERROR ***
Node: BBEnd n2n
Method: file:line:name
Node cannot live across block boundary at n7n

...

[----------] 484 tests from IfxcmpgeReductionTest/UInt64ReductionTest
[----------] 484 tests from IfxcmpgeReductionTest/UInt64ReductionTest (186 ms total)

[----------] 156 tests from VectorArithmetic/ParameterizedBinaryVectorArithmeticTest
Assertion failed at ../omr/compiler/aarch64/codegen/OMRTreeEvaluator.cpp:3828: false
        Opcode badd is not implemented
compiling file:line:name at level: warm

[1]    5138 trace trap  ./fvtest/compilertriltest/comptest

@knn-k
Copy link
Contributor Author

knn-k commented Sep 28, 2022

omrporttest calls omrmem_allocate_memory32(), which always returns NULL on AArch64 macOS.
But that is not the reason of "Could not find 0x4000 bytes available with page size 0x4000". That is a different problem.

@knn-k
Copy link
Contributor Author

knn-k commented Sep 30, 2022

I opened Issue #6739 for omrsysinfo_get_processor_description() on macOS.

@knn-k
Copy link
Contributor Author

knn-k commented Sep 30, 2022

PR #6741 improves omrporttest.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 3, 2022

PR #6742 fixes a failure with sysinfo in omrporttest.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 5, 2022

I see socket failures with omrporttest on AArch64 Mac, which look the same as Issue #6516 on Intel Mac.

[----------] 19 tests from PortSockTest
/Users/openj9/omr/fvtest/porttest/omrsockTest.cpp:1209: Failure
      Expected: rc
      Which is: 1
To be equal to: 2
[  FAILED  ] PortSockTest.poll_functionality_basic (1011 ms)
/Users/openj9/omr/fvtest/porttest/omrsockTest.cpp:51: Failure
      Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
      Which is: -506
To be equal to: 0
/Users/openj9/omr/fvtest/porttest/omrsockTest.cpp:1259: Failure
      Expected: privateOmrPortLibrary->sock_accept(privateOmrPortLibrary, serverSocket, &connectedServerSockAddr, &connectedServerSocket)
      Which is: -20
To be equal to: 0
[  FAILED  ] PortSockTest.poll_functionality_many_sockets (1 ms)

@knn-k
Copy link
Contributor Author

knn-k commented Oct 6, 2022

The latest failures from https://ci.eclipse.org/omr/job/PullRequest-osx_aarch64/16/

14:52:50  The following tests FAILED:
14:52:50  	  3 - conditionals_example_as_test (SEGFAULT)
14:52:50  	  5 - iterfib_example_as_test (SEGFAULT)
14:52:50  	  6 - nestedloop_example_as_test (SEGFAULT)
14:52:50  	  7 - pow2_example_as_test (SEGFAULT)
14:52:50  	  8 - simple_example_as_test (SEGFAULT)
14:52:50  	  9 - worklist_example_as_test (SEGFAULT)
14:52:50  	 25 - JitBuilderTest (SEGFAULT)
14:52:50  	 26 - CompilerTest (SIGTRAP)
14:52:50  	 28 - comptest (SIGTRAP)

@knn-k
Copy link
Contributor Author

knn-k commented Oct 12, 2022

I reviewed and merged PR #6760.
The latest test result (https://ci.eclipse.org/omr/job/PullRequest-osx_aarch64/18/) looks like this:

[2022-10-12T06:02:15.447Z] The following tests FAILED:
[2022-10-12T06:02:15.447Z] 	 14 - porttest (Failed)
[2022-10-12T06:02:15.447Z] 	 25 - JitBuilderTest (SIGTRAP)
[2022-10-12T06:02:15.447Z] 	 26 - CompilerTest (SIGTRAP)
[2022-10-12T06:02:15.447Z] 	 28 - comptest (SIGTRAP)

@Akira1Saitoh
Copy link
Contributor

#6761 improves compilertest.

@knn-k
Copy link
Contributor Author

knn-k commented Oct 13, 2022

#6763 resolved the failure with JitBuilderTest.

@knn-k
Copy link
Contributor Author

knn-k commented Nov 2, 2022

I opened two fixes: #6792 (normalizeNaN) and #6793 (unordered fcmp/dcmp)

@knn-k
Copy link
Contributor Author

knn-k commented Nov 2, 2022

PR #6793 was merged, and now comptest finishes without SIGTRAP caused by the assertion failure.
The remaining comptest failures are with FloatIfCompare/DoubleIfCompare (Issue #6790).

https://ci.eclipse.org/omr/job/PullRequest-osx_aarch64/41/

[2022-11-02T13:54:13.073Z] 28/29 Test #28: comptest ..........................***Failed   47.43 sec

@knn-k
Copy link
Contributor Author

knn-k commented Nov 9, 2022

All the fvtest failures on AArch64 macOS have been resolved, except for the intermittent failure with sockets (#6516).
Closing this issue.

@knn-k knn-k closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants