AArch64 macOS: Implement omrsysinfo_get_processor_description()

[knn-k]

This commit implements omrsysinfo_get_processor_description() for AArch64 macOS.

Closes: #6739

Signed-off-by: KONNO Kazuhiro [email protected]

[knn-k]

The failures with PortSockTest on x86 macOS are known as Issue #6516.

[knn-k]

This commit enables the use of optional atomic instructions (OMR_FEATURE_ARM64_LSE) on AArch64 macOS.

omr/compiler/aarch64/codegen/OMRTreeEvaluator.cpp

Line 5030 in dc16371

if (comp->target().cpu.supportsFeature(OMR_FEATURE_ARM64_LSE) && (!disableLSE))

https://github.com/eclipse-openj9/openj9/blob/adf9c099f62dd206727721ddbfbe9de931870bff/runtime/compiler/aarch64/codegen/J9TreeEvaluator.cpp#L3680

OMR_FEATURE_ARM64_LSE is the only optional feature that is checked in AArch 64 code generation of OMR and OpenJ9 at the moment.
I ran sanity.functional on AArch64 macOS in the OpenJ9 project, to make sure it does not break anything.

[0xdaryl]

Can't test on macOS until #6637 is ready.

[0xdaryl]

Jenkins build aarch64

[0xdaryl]

@babsingh : could you review the port lib changes please?

[babsingh]

Please only correct code that has been modified and near-by instances for coding standard. Near-by instances should not exceed the limits of the function which was modified.

I have been misinterpreted in the past, and the author ended up fixing the entire file for coding standard.

[knn-k]

Jenkins build all

[knn-k]

Jenkins build zos

[knn-k]

Jenkins build riscv

RISC-V timed out.

[babsingh]

This is my last feedback. Everything else looks good. The PR will be merged after this request is addressed. Since there are no amacs on OMR Jenkins, can you confirm if local testing on an amac has passed?

[knn-k]

This PR resolves a failure with PortSysinfoTest in omrporttest on AArch64 macOS as the output below shows.
There are two failures with PortSockTest, which need to be addressed by Issue #6516.

[----------] 38 tests from PortSysinfoTest
originalSoftLimit=256
originalHardLimit=24576
soft set to hard limit=24576
[----------] 38 tests from PortSysinfoTest (7457 ms total)


[==========] 244 tests from 21 test cases ran. (45284 ms total)
[  PASSED  ] 242 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] PortSockTest.poll_functionality_basic
[  FAILED  ] PortSockTest.poll_functionality_many_sockets

[knn-k]

Jenkins build aarch64

[babsingh]

All PR builds have passed in the previous run. The most recent change only adjusts line spacing. The PR will be merged after the recent auto-run and aarch64 builds pass.