Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset on stack buffer pointer for iconv #5697

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Reset on stack buffer pointer for iconv #5697

merged 1 commit into from
Dec 2, 2020

Conversation

JasonFengJ9
Copy link
Contributor

This prevents buffer overrun when there is second round iconv() call within convertWideToPlatform().

Signed-off-by: Jason Feng [email protected]

@0xdaryl
Copy link
Contributor

0xdaryl commented Dec 1, 2020

@babsingh : please review

babsingh
babsingh requested changes Dec 2, 2020
View reviewed changes
port/common/omrstr.c Outdated Show resolved Hide resolved
babsingh
babsingh reviewed Dec 2, 2020
View reviewed changes
port/common/omrstr.c Outdated Show resolved Hide resolved
babsingh
babsingh requested changes Dec 2, 2020
View reviewed changes
port/common/omrstr.c Outdated Show resolved Hide resolved
port/common/omrstr.c Outdated Show resolved Hide resolved
port/common/omrstr.c Outdated Show resolved Hide resolved
@JasonFengJ9
Reset on-stack buffer pointer for iconv
d64765a 
This prevents buffer overrun when there is second round iconv() call
within convertWideToPlatform.

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9
Copy link
Contributor Author 

2020-12-02T12:58:39.8788040Z 31: [  PASSED  ] 234 tests.
2020-12-02T12:58:39.8788380Z 31: [  FAILED  ] 2 tests, listed below:
2020-12-02T12:58:39.8789350Z 31: [  FAILED  ] PortSockTest.poll_functionality_basic
2020-12-02T12:58:39.8789880Z 31: [  FAILED  ] PortSockTest.poll_functionality_many_sockets

These failures seem not related this PR.

babsingh
babsingh approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@babsingh
Copy link
Contributor

babsingh commented Dec 2, 2020

@genie-omr build all

@0xdaryl 0xdaryl self-assigned this Dec 2, 2020
@0xdaryl
Copy link
Contributor

0xdaryl commented Dec 2, 2020

@genie-omr build all

@0xdaryl
Copy link
Contributor

0xdaryl commented Dec 2, 2020

macOS failure is likely #5581.

@0xdaryl 0xdaryl merged commit ce764b4 into eclipse:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

@0xdaryl 0xdaryl 0xdaryl approved these changes

@charliegracie charliegracie Awaiting requested review from charliegracie

@rwy7 rwy7 Awaiting requested review from rwy7

@youngar youngar Awaiting requested review from youngar

Assignees

@0xdaryl 0xdaryl

Labels
comp:port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonFengJ9 @0xdaryl @babsingh