Add new core dump tool for OSX #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikezhang1234567890
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
FYI @manqingl |
|
@klangman @JamesKingdon : FYI |
|
On one of the Open9 DDR tests, the utility creates a vastly inflated core file (100GB+) running the following command: Looking into the issue now. |
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
8fae4d1
to
df293fe
Compare
|
Fixed the issue with core file size inflation. This PR is ready for review. |
keithc-ca
suggested changes
May 27, 2021
|
Updated the PR, can you take another look please @keithc-ca |
keithc-ca
reviewed
Jun 7, 2021
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
c8376ec
to
e257dad
Compare
|
@keithc-ca I've updated the PR, can you take another look please? |
keithc-ca
suggested changes
Jul 7, 2021
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
e257dad
to
2f9ea8d
Compare
|
@keithc-ca Updated the PR again. |
keithc-ca
suggested changes
Jul 8, 2021
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
2f9ea8d
to
e7d0cd3
Compare
keithc-ca
approved these changes
Jul 12, 2021
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
e7d0cd3
to
c88ec5b
Compare
|
Squashed commits into one. |
Dumping core using the signal requires an the task-get-allow entitlement, which prevents notarization. Thus we dump the core with a user space tool which does not require an entitlement. Signed-off-by: Mike Zhang <[email protected]>
mikezhang1234567890
force-pushed
the
osx-ddr
branch
from
c88ec5b
to
cfed42b
Compare
|
Jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping core using the signal requires an the task-get-allow
entitlement, which prevents notarization. Thus we dump the core
with a user space tool which does not require an entitlement.
Signed-off-by: Mike Zhang [email protected]
Resolves #5813
fyi @keithc-ca