-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems compiling with gcc 10 #6301
Conversation
Windows is not cooperating:
And it seems the added assertion needs to be relaxed:
|
Updated to make allowances for MSVC and to relax the new assertion. |
jenkins build all |
Apparently, it's only GCC that supports extending a class containing a flexible array member: adjusted accordingly. Longer term we ought to eliminate extensions to |
jenkins build all |
Updated so clang is not treated as gcc. |
jenkins build all |
Jenkins build xlinux |
Use a flexible array for RegisterDependencyGroup._dependencies (only for gcc), and promote architecture-specific fields so they don't follow that array whose size is determined dynamically at runtime. Signed-off-by: Keith W. Campbell <[email protected]>
jenkins build all |
@jdmpapin do you mind reviewing this one? |
As mentioned in the slack channel, zos build passing depends on #6292 |
jenkins build zos |
@jdmpapin Do you have any concerns with this? |
Use a flexible array for
RegisterDependencyGroup._dependencies
, and promote architecture-specific fields so they don't follow that flexible array.Fixes: eclipse-openj9/openj9#14219.