Add External Relocation Record TR_StaticDefaultValueInstance #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
requested review from
vijaysun-omr,
Leonardo2718,
0xdaryl and
mstoodle
as code owners
a7ehuo
force-pushed
the
static-allocation-defaultvalue-aot-2
branch
from
fa728dd
to
dc8be8d
Compare
1 task
a7ehuo
requested review from
dsouzai and
hzongaro
and removed request for
Leonardo2718,
mstoodle,
0xdaryl and
vijaysun-omr
|
This PR should be review along with eclipse-openj9/openj9#15666 which is the change that implements the new |
|
@dsouzai @hzongaro May I ask you to review this change along with eclipse-openj9/openj9#15666? Thank you! |
hzongaro
reviewed
Aug 5, 2022
dsouzai
requested changes
Aug 5, 2022
a7ehuo
force-pushed
the
static-allocation-defaultvalue-aot-2
branch
from
dc8be8d
to
1cd0e50
Compare
hzongaro
reviewed
Aug 9, 2022
This relocation record is used to materialize value type default value instance slot address: `&clazz->flattenedClassCache->defaultValue` IL: - Add `StaticDefaultValueInstance` flag to `Symbol` to indicate if the symbol is for default value instance slot address X86: - Add relocation record in AMD64RegImm64SymInstruction for `TR_StaticDefaultValueInstance` relocation type. Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
static-allocation-defaultvalue-aot-2
branch
from
1cd0e50
to
c2b24eb
Compare
dsouzai
approved these changes
Aug 9, 2022
|
osx failures seem to be due to #6516 jenkins build all |
failure due to #6556 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relocation record is used to materialize value type default value instance slot address:
&clazz->flattenedClassCache->defaultValueIL:
StaticDefaultValueInstanceflag toSymbolto indicateif the symbol is for default value instance slot address
X86:
TR_StaticDefaultValueInstancerelocation type.Signed-off-by: Annabelle Huo [email protected]