Define suppressEA option and implement regular expression matching based on a location in IL #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the suppressEA option. The intent is that a downstream project can use the option to suppress stack allocations at matching locations that might be performed in an Escape Analysis optimization.
hzongaro
force-pushed
the
suppressEA-regex-option
branch
from
441ce06
to
7ae1655
Compare
|
Removed stray trailing whitespace |
|
Devin @jdmpapin, may I ask you to review this change? |
jdmpapin
reviewed
Jan 31, 2023
jdmpapin
reviewed
Jan 31, 2023
This change defines a new SimpleRegex::match method that will match a
regular expression against a location in a sequence of inlined method
invocations that are described by a TR_ByteCodeInfo. The
TR_ByteCodeInfo is rendered as strings of the form
and
@<bc-offset>{#<inlined-method-sig>@<bc-offset>}*
where each <bc-offset> is the bytecode offset from the start of a
method, and each <method-sig> is the signature of the outermost method
or an inlined method invocation. If either string matches the specified
regular expression, the match is successful. That makes the outermost
method signature optional in the specified regular expression.
hzongaro
force-pushed
the
suppressEA-regex-option
branch
from
ecc34b7
to
d4589b4
Compare
Done |
|
Jenkins build all |
|
The Mac failure is #6516 |
|
All other checks have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the
suppressEAoption. The intent is that a downstream project can use the option to suppress stack allocations at matching locations that might be performed in an Escape Analysis optimization.The other part of the change defines a new
TR::SimpleRegex::matchmethod that will match a regular expression against a location in a sequence of inlined method invocations that are described by aTR_ByteCodeInfo. TheTR_ByteCodeInfois rendered as strings of the formand
where each <bc-offset> is the bytecode offset from the start of a method, and each <method-sig> is the signature of the outermost method or an inlined method invocation. If either string matches the specified regular expression, the match is successful. That makes the outermost method signature optional in the specified regular expression.
It is likely that projects taking advantage of the
suppressEAoption will use this new form of regular expression matching.