Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isNullRestricted field to TypeLayoutEntry #7125

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add isNullRestricted field to TypeLayoutEntry #7125

merged 1 commit into from
Oct 17, 2023

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Sep 25, 2023 •
edited
Loading

This was referenced Sep 25, 2023
Merged
Open
@a7ehuo a7ehuo marked this pull request as ready for review September 27, 2023 12:22
@a7ehuo a7ehuo requested review from hzongaro and removed request for mstoodle and 0xdaryl September 27, 2023 12:22
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Sep 27, 2023

@hzongaro May I ask you to review this change? Thanks!

I'm keeping WIP for now because this PR depends on eclipse-openj9/openj9#18189. My understanding is that it requires a coordinated merge

hzongaro
hzongaro approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

hzongaro commented Oct 4, 2023

Jenkins build all

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 4, 2023

eclipse-omr/pr/win_x86-64 failure: Not sure how it's related to this change. A previous PR build seems having similar failures.

22:32:54  The following tests FAILED:
22:32:54  	  2 - conditionals_example_as_test (Not Run)
22:32:54  	  3 - isSupportedType_example_as_test (Not Run)
22:32:54  	  4 - iterfib_example_as_test (Not Run)
22:32:54  	  5 - nestedloop_example_as_test (Not Run)
22:32:54  	  6 - pow2_example_as_test (Not Run)
22:32:54  	  7 - simple_example_as_test (Not Run)
22:32:54  	  8 - worklist_example_as_test (Not Run)
22:32:54  	  9 - power_example_as_test (Not Run)
22:32:54  Errors while running CTest
...
22:32:58  ERROR: Cannot delete workspace :Unable to delete 'c:\omr\workspace\PullRequest-win_x86-64\Build'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts. (Discarded 2 additional exceptions)

x86-64 macOS failure: known issue #6516

/Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1209
      Expected: rc
      Which is: 1
To be equal to: 2

/Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:51
      Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
      Which is: -506
To be equal to: 0

@hzongaro
Copy link
Member

hzongaro commented Oct 4, 2023

Jenkins build osx,win

@hzongaro
Copy link
Member

Jenkins build win

1 similar comment
@hzongaro
Copy link
Member

Jenkins build win

@a7ehuo a7ehuo changed the title WIP: Add isNullRestricted field to TypeLayoutEntry Add isNullRestricted field to TypeLayoutEntry Oct 13, 2023
@hzongaro hzongaro merged commit 16c71a7 into eclipse:master Oct 17, 2023
16 of 18 checks passed
@a7ehuo a7ehuo deleted the typelayout-add-nullRestricted branch March 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

Assignees
No one assigned
Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a7ehuo @hzongaro