Fix bug related to CodeCache utilization reporting #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR eclipse#7129 moved the code that writes a TR::CodeCache pointer into the beginning of the code cache segment towards the end of the OMR::CodeCache::initialize routine. This makes sense because we want to 'advertise' to the world the newly created TR::CodeCache structure only after this structure has been fully initialized. However, OMR::CodeCache::initialize() routine contains an early return that is taken when the JIT does not need trampolines. On this path we no longer write the TR::CodeCache pointer into the beginning of the code cache segment and the VM is unable to retrieve code cache utilization statistics. This commit avoid the early return mentioned above. Signed-off-by: Marius <[email protected]>
|
@dsouzai Could you please review/merge this PR? Thanks |
dsouzai
approved these changes
Oct 10, 2023
|
jenkins build all |
|
eclipse.omr test failure due to #6516 |
|
windows error because or infra issue: |
|
jenkins build win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7129 moved the code that writes a TR::CodeCache pointer into the beginning of the code cache segment towards the end of the
OMR::CodeCache::initialize routine. This makes sense because we want to 'advertise' to the world the newly created TR::CodeCache structure only after this structure has been fully initialized.
However, OMR::CodeCache::initialize() routine contains an early return that is taken when the JIT does not need trampolines. On this path we no longer write the TR::CodeCache pointer into the beginning of the code cache segment and the VM is unable to retrieve code cache utilization statistics.
This commit avoid the early return mentioned above.