Add can skip null value store check

[a7ehuo]

Add CanSkipNonNullableArrayNullStoreCheck for recognized method.

This change is used by the change in:

• Add and use a list of methods that can skip null value store check eclipse-openj9/openj9#18464

[a7ehuo]

@hzongaro May I ask you to review this change? Thank you!

[hzongaro]

I think your changes look good.

One thing I notice is that the non-helper that's used for checking for stores of null references to null-restricted arrays is called <nonNullableArrayNullStoreCheck>. Of course, the terminology that's being used in the downstream project has changed over time. I think the names of skip..., safeToSkip... and CanSkip... should be consistent with the name of the non-helper, and they should either all use nonNullableArrayNullStoreCheck or all use nullValueStoreCheckForNullRestrictedArray.

If you decide to go use with NullRestricted rather than nonNullable , it might be good to trim the length a bit - maybe something like nullRestrictedArrNullStoreCheck.

[a7ehuo]

the non-helper that's used for checking for stores of null references to null-restricted arrays is called .

Good point! I'll update the name to skipNonNullableArrayNullStoreCheck etc.

[a7ehuo]

@hzongaro The comment is addressed. Ready for another review. Thanks!

[hzongaro]

Looks good. Thanks!

[hzongaro]

Jenkins build all

[a7ehuo]

x86-64 macOS test failure:

The following tests FAILED:
	  2 - TestJitBuilderAPIGenerator (Failed)
	 34 - porttest (Failed)

• TestJitBuilderAPIGenerator is tracked in TestJitBuilderAPIGenerator failure: no attribute assertRegexpMatches #7181
• porttest is tracked in OSX PR builds: OMR Socket Test Failures #6516

Linux riscv64 failure:

20:56:13  + docker build -t riscv-crosscompile .
...
20:56:13  Step 12/19 : RUN wget -O /tmp/libfakeroot_1.31-1.2_riscv64.deb 	 http://ftp.ports.debian.org/debian-ports/pool-riscv64/main/f/fakeroot/libfakeroot_1.31-1.2_riscv64.deb
20:56:13   ---> Running in 10ba7d861f73
20:56:13  �[91m--2023-11-20 20:56:11--  http://ftp.ports.debian.org/debian-ports/pool-riscv64/main/f/fakeroot/libfakeroot_1.31-1.2_riscv64.deb
20:56:13  Resolving ftp.ports.debian.org (ftp.ports.debian.org)... �[0m�[91m130.89.148.77, 2001:67c:2564:a119::77
20:56:13  Connecting to ftp.ports.debian.org (ftp.ports.debian.org)|130.89.148.77|:80... �[0m�[91mconnected.
20:56:13  �[0m�[91mHTTP request sent, awaiting response... �[0m�[91m404 Not Found
20:56:13  �[0m�[91m2023-11-20 20:56:11 ERROR 404: Not Found.
20:56:13  
20:56:13  �[0mThe command '/bin/sh -c wget -O /tmp/libfakeroot_1.31-1.2_riscv64.deb 	 http://ftp.ports.debian.org/debian-ports/pool-riscv64/main/f/fakeroot/libfakeroot_1.31-1.2_riscv64.deb' returned a non-zero code: 8
...
ERROR: script returned exit code 8
Setting status of aebf7ddc236c5fda1aa2e7803e858877775102b6 to FAILURE with url https://ci.eclipse.org/omr/job/PullRequest-linux_riscv64_cross/1278/ and message: 'Build finished. '

It looks to me an infrastructure issue.

[hzongaro]

Jenkins build riscv

[hzongaro]

Except for known problems, builds were all successful. Merging.