Use gcThreadCountSpecified #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of newly introduced gcThreadCountSpecified flag so that when command line options (such as Java's -Xgcthreads or -Xgcmaxthreads) are specified, GC thread count overrides the default count calculation. Old gcThreadCountForced flag is still used, butin ParallelDispatcher to distinguish between force/fixed or adaptive count of threads, bufore deciding how many threads to use for a ParallelTask. Another change is that during the snapshot VM creation when thread count is reduced to checkpointGCthreadCount, we don't adjust GCExtensions gcThreadCount anymore (only ParallelDispatcher is affected). This is to be able to carry over the original count (from snapshot VM) to restore VM, so that options that specify that count can be obeyed even on restore side.
|
@dmitripivkine please, review |
dmitripivkine
approved these changes
Dec 19, 2023
|
@babsingh please, review |
|
jenkins build all |
|
Only known and unrelated failures are seen in the PR builds: |
babsingh
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of newly introduced gcThreadCountSpecified flag so that when command line options (such as Java's -Xgcthreads or -Xgcmaxthreads) are specified, GC thread count overrides the default count calculation.
Old gcThreadCountForced flag is still used, butin ParallelDispatcher to distinguish between force/fixed or adaptive count of threads, bufore deciding how many threads to use for a ParallelTask.
Another change is that during the snapshot VM creation when thread count is reduced to checkpointGCthreadCount, we don't adjust GCExtensions gcThreadCount anymore (only ParallelDispatcher is affected). This is to be able to carry over the original count (from snapshot VM) to restore VM, so that options that specify that count can be obeyed even on restore side.